| commit | 96f29a136fc8d2875b7e46fd785fded23dbecca5 | [log] [tgz] |
|---|---|---|
| author | Lily Chen <[email protected]> | Wed Apr 15 17:59:36 2020 |
| committer | Commit Bot <[email protected]> | Wed Apr 15 17:59:36 2020 |
| tree | 1cb99c43f81c36c4fcc4674b2654caad57baa0e8 | |
| parent | 65291297941d91b3c1f254e5e5b91635bded77e9 [diff] |
Pass source URL when setting a cookie Instead of only passing the scheme of the cookie's source, this now passes the whole URL. Most of the call sites already have the URL (e.g. they used it to create the cookie object in the first place). These callers were previously passing url.scheme() and were converted to just pass the url. Some callers did not have the source URL. These were converted to use a fake URL cobbled together from the original scheme, the cookie's domain attribute, and the cookie's path attribute. Most of these call sites were in tests, but a handful were in production code. As of now, the use of a simulated source URL doesn't matter (since the CookieStore implementation only uses its scheme anyway). Bug: 1069642 Change-Id: If239280a3d43b7c0e2ff9af9daa9989350957b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145152 Commit-Queue: Lily Chen <[email protected]> Reviewed-by: Achuith Bhandarkar <[email protected]> Reviewed-by: Mikel Astiz <[email protected]> Reviewed-by: Boris Sazonov <[email protected]> Reviewed-by: Wez <[email protected]> Reviewed-by: Richard Coles <[email protected]> Reviewed-by: Maksim Orlovich <[email protected]> Reviewed-by: John Abd-El-Malek <[email protected]> Reviewed-by: Tom Sepez <[email protected]> Reviewed-by: Becca Hughes <[email protected]> Reviewed-by: Kyle Horimoto <[email protected]> Reviewed-by: Eugene But <[email protected]> Reviewed-by: Joshua Bell <[email protected]> Reviewed-by: Tarun Bansal <[email protected]> Reviewed-by: Wei Li <[email protected]> Reviewed-by: Karan Bhatia <[email protected]> Cr-Commit-Position: refs/heads/master@{#759324}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.