Move all SiteURL and lock URL computations to SiteInfo.
This change moves all site URL and lock URL generation out of
SiteInstanceImpl and into SiteInfo. This allows all details related
to the creation of these URLs to be hidden from other classes. Tests
were updated to use the new methods. ProcessLock creation was modified
slightly to make it easier to hide threading concerns related to
ProcessLocks and their related SiteInfos. A test was also added to verify
that ProcessLocks created on different threads match even though the
underlying SiteInfos do no. This should help prevent this behavior from
accidentally regressing in the future. There should not be any
user visible behavior changes introduced by this patch. It is primarily
just moving code around and renaming things.
Bug: 1085275
Change-Id: I46794960f2bb669c2e6e2750e139dc25cd03ae84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2680068
Reviewed-by: Nasko Oskov <[email protected]>
Commit-Queue: Aaron Colwell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#853243}
diff --git a/content/browser/renderer_host/navigator_unittest.cc b/content/browser/renderer_host/navigator_unittest.cc
index 6a3f6d8..a35b6fc7 100644
--- a/content/browser/renderer_host/navigator_unittest.cc
+++ b/content/browser/renderer_host/navigator_unittest.cc
@@ -1252,7 +1252,7 @@
if (AreDefaultSiteInstancesEnabled()) {
ASSERT_TRUE(related_instance_impl->IsDefaultSiteInstance());
} else {
- EXPECT_EQ(SiteInstanceImpl::ComputeSiteInfoForTesting(
+ EXPECT_EQ(SiteInfo::CreateForTesting(
current_instance->GetIsolationContext(), kUrlSameSiteAs2),
related_instance_impl->GetSiteInfo());
}
