commit a063c102fd36f61f4a0a01447f4b01ace4ffccdf
author jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Thu Jul 22 22:20:19 2010
committer jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Thu Jul 22 22:20:19 2010
tree 801c4319279c82261b9b3a8f4214f79bd5a4767d
parent 2f66099544951cddee4f58543a66fe41018e2c02

Change to (quieter) NOTREACHED() rather than (noisy) LOG(DFATAL)

bug=46576
r=thestig
Review URL: http://codereview.chromium.org/2884033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53402 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/metrics/metrics_service.cc

diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc
index 9a93091..45af9bfc 100644
--- a/chrome/browser/metrics/metrics_service.cc
+++ b/chrome/browser/metrics/metrics_service.cc
@@ -653,7 +653,7 @@
       break;
     }
     default:
-      LOG(DFATAL);
+      NOTREACHED();
       break;
   }
 
@@ -858,7 +858,7 @@
 void MetricsService::SaveLocalState() {
   PrefService* pref = g_browser_process->local_state();
   if (!pref) {
-    LOG(DFATAL);
+    NOTREACHED();
     return;
   }
 
@@ -1149,7 +1149,7 @@
       break;
 
     default:
-      LOG(DFATAL);
+      NOTREACHED();
       return;
   }
 
@@ -1380,7 +1380,7 @@
       return "FAILED";
 
     default:
-      LOG(DFATAL);
+      NOTREACHED();
       return "Unknown";
   }
 }
@@ -1442,7 +1442,7 @@
         break;
 
       default:
-        LOG(DFATAL);
+        NOTREACHED();
         break;
     }
 
@@ -1684,7 +1684,7 @@
       break;
 
     default:
-      LOG(DFATAL);
+      NOTREACHED();
       return;
   }
 
@@ -1778,7 +1778,7 @@
       break;
 
     default:
-      LOG(DFATAL) << "Unexpected notification type " << type.value;
+      NOTREACHED() << "Unexpected notification type " << type.value;
       return;
   }
 }
@@ -1838,7 +1838,7 @@
   for (ListValue::iterator value_iter = plugins->begin();
        value_iter != plugins->end(); ++value_iter) {
     if (!(*value_iter)->IsType(Value::TYPE_DICTIONARY)) {
-      LOG(DFATAL);
+      NOTREACHED();
       continue;
     }
 
@@ -1846,7 +1846,7 @@
     std::wstring plugin_name;
     plugin_dict->GetString(prefs::kStabilityPluginName, &plugin_name);
     if (plugin_name.empty()) {
-      LOG(DFATAL);
+      NOTREACHED();
       continue;
     }