| commit | a62d9c0d27dde694f4f7757f0817ff8ea722c5bd | [log] [tgz] |
|---|---|---|
| author | Brett Wilson <[email protected]> | Wed Sep 20 20:53:20 2017 |
| committer | Commit Bot <[email protected]> | Wed Sep 20 20:53:20 2017 |
| tree | 13f86c5a1a4ecc2718baeefdecb0a3247042bd12 | |
| parent | d15b8aea034b3ee1d4d29b4953fa16812ac88af3 [diff] |
Convert many std::queue to base::queue Fix self-assignment of circular_deque which was asserted. This was exposed by the ClientSideDetectionServiceTest tests. Convert the std::queue in reporter_runner_win.h to a circular_deque instead of a base::queue. This one wants to check container contents equality which is (deliberately) not supported by circular_deque (which underlines base::queue and means base::queue equality also doesn't work). By converting to a circular_deque, the iterators can be used to run std::equal. We are standardizing on the base variant of deque and queue. This saves 6.8K code size on Linux 64. Convert typedefs to using statements in affected code. Bug: 757232 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6af98d213cb5a4202155683b8be38b2d31076f1b Reviewed-on: https://chromium-review.googlesource.com/673554 Commit-Queue: Brett Wilson <[email protected]> Reviewed-by: Scott Violet <[email protected]> Cr-Commit-Position: refs/heads/master@{#503241}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .