Google Git
Sign in
chromium / chromium / src.git / aae1e8824f3109d26e7ea9ef478a70e695c3a568
commitaae1e8824f3109d26e7ea9ef478a70e695c3a568[log] [tgz]
authorMarijn Kruisselbrink <[email protected]>Fri Sep 23 22:54:17 2022
committerChromium LUCI CQ <[email protected]>Fri Sep 23 22:54:17 2022
tree65b95e43d1f763c02c07c9e4a858e3b5af2ce639
parentff81d4096cfd202cafb49355a84a15e58b1c3a19 [diff]
Improve how blobs are passed over extension function responses.

Previously blobs were passed as their UUID encoded as strings in
the base::Value response data. The renderer code on receiving this
would then send back the UUID to the browser process to construct
the actual Blob object. The Blob backend however has been phasing out
usage of UUIDs, especially for passing blobs over IPC, as a major
challenge with this scheme is keeping the blobs alive in the backend
long enough for the renderer to be able to acquire a handle/reference
to the blob (resulting in flaky tests/failures with the service
worker version of the printerProvider API).

This CL changes this logic by instead passing blobs over IPC as the
actual Blob handle. This guarantees that the blob stays alive, and
eliminates the need for extra round trips and book keeping after the
response reaches the renderer.

Bug: 1196789, 1292030, 740744
Change-Id: Ifb7e235ef64fd57d3a8709ca3f54a47c22082b4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3863293
Reviewed-by: Tim <[email protected]>
Reviewed-by: Matthew Denton <[email protected]>
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Devlin Cronin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1050833}
42 files changed
tree: 65b95e43d1f763c02c07c9e4a858e3b5af2ce639
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.