Google Git
Sign in
chromium / chromium / src.git / b8e0df0bccb6cee5bd774b782023b3207fde6eda
commitb8e0df0bccb6cee5bd774b782023b3207fde6eda[log] [tgz]
authorDavid Bokan <[email protected]>Wed May 14 22:03:48 2025
committerChromium LUCI CQ <[email protected]>Wed May 14 22:03:48 2025
tree1e28c47df3fff6c1ffbc530176e35aade3c05b48
parenta13c85401eb683a9d8806b06e302943ffb849c28 [diff]
Make history tool resilient to different kinds of async

The linked bug was occurring on pages that had a beforeunload handler,
though they didn't result in a beforeunload prompt. The reason is that
the tool was assuming that a navigation-starting task will have been
posted in the call to GoBack|GoForward. However, in the beforeunload
case navigation code actually has to wait on a renderer response before
deciding on whether to issue the navigation.

This CL plumbs through the list of created (but not-yet-started)
navigations through the content API, allowing the tool to know how many
navigations are expected. It then tracks which of these navigations has
started, checking for cancellations via polling.

Bug: 415385900
Change-Id: Iee244642016152d9e76fc4ab6903691ef0d23d04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6533422
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: David Bokan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1460387}
7 files changed
tree: 1e28c47df3fff6c1ffbc530176e35aade3c05b48
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. SECURITY_OWNERS
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.