| commit | bfd1f02972229e2e0b949769708e86ff9d3af097 | [log] [tgz] |
|---|---|---|
| author | Dominic Farolino <[email protected]> | Wed Mar 23 19:12:24 2022 |
| committer | Chromium LUCI CQ <[email protected]> | Wed Mar 23 19:12:24 2022 |
| tree | 2e7f4ab9754e364d6824741e51508d96efb62bc2 | |
| parent | 40c8489e28b5c9383e1b4f39ce479f773cca2e51 [diff] |
Fenced Frames: Introduce mode attribute
This CL introduces the `mode` IDL attribute which reflects the following
values:
- "default"
- "opaque-ads"
It also introduces a method in html_fenced_frame_element.cc that turns
attribute values into a new mojo type FencedFrameMode that this CL
introduces.
This CL also introduces a new FramePolicy member alongside the existing
`is_fenced` member, for ShadowDOM-based-fenced-frames only, that
represents the "mode" of a particular fenced frame. A fenced frame's
mode should never change, and we have a few methods of protection for
this:
1.) HTMLFencedFrameElement::ParseAttribute() ensures that once parsed,
the mode attribute cannot change
2.) The browser process checks that when the FramePolicy is modified,
the fenced frame's mode never changes. If it does, it bad-messages
the renderer
With this, we also implement HTMLFencedFrameElement creation
restrictions that prevent a fenced frame of one mode from being created
inside a fenced frame of another mode. This is only done for ShadowDOM,
since we trivially piggy-back off of the FramePolicy mechanism that is
replicated across frames. The MPArch implementation will require more
work.
Bug: 1123606
Change-Id: Ibad432057fe7550add5d86c9f9bbd88d0c9c59cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3466817
Reviewed-by: Shivani Sharma <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Dominic Farolino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#984466}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.