Google Git
Sign in
chromium / chromium / src.git / c3dadb02f611a360fb40fd8844ed3c1ef1e7834e
commitc3dadb02f611a360fb40fd8844ed3c1ef1e7834e[log] [tgz]
authorPeter Kasting <[email protected]>Tue Sep 17 22:44:54 2024
committerChromium LUCI CQ <[email protected]>Tue Sep 17 22:44:54 2024
tree4814bbd120f313bb5dbedb41e97417f3ddd0e844
parentec3e7f2edc16d23abee28e566615a12dd7b573fe [diff]
More consistent macro definitions in base/compiler_specific.h.

* Except in PartitionAlloc (which still supports C++17), eliminate
  `HAS_CPP_ATTRIBUTE`, since `__has_cpp_attribute` is standard in C++20
  and all our compilers support it, and it's not used outside
  compiler_specific.h.
* Prefer standard-C++-style attributes to GCC-style ones whenever
  possible. These have a more restricted set of places they can appear,
  so this requires some minor callsite tweaks.
* Directly test for the attributes being used instead of looking at
  which compiler is being used. In a few cases this will likely result
  in the gcc build getting the intended attribute "for free".
* Streamline some redundant, verbose, or technically inaccurate
  definitions.

Bug: none
Change-Id: I1c133f1719d4500dfd22ab3158b629d17ca07d6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5851576
Reviewed-by: danakj <[email protected]>
Auto-Submit: Peter Kasting <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1356780}
6 files changed
tree: 4814bbd120f313bb5dbedb41e97417f3ddd0e844
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitallowed
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. CPPLINT.cfg
  76. CRYPTO_OWNERS
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.