| commit | c46e4d0226b8bdf569eca476ec33802878db6555 | [log] [tgz] |
|---|---|---|
| author | Daniel Cheng <[email protected]> | Tue Jun 24 18:41:28 2025 |
| committer | Chromium LUCI CQ <[email protected]> | Tue Jun 24 18:41:28 2025 |
| tree | 5726c740de4e45a13c9999d202da3f3c0b0df5c6 | |
| parent | e63e1979aaae1e3697438b327f80f69b1831aeac [diff] |
Fix C++23 compile error in base::DictValue In C++23, T must be complete definition when destroying a std::unique_ptr<T> using the default deleter. This particular instance is a bit tricky: base::DictValue needs to be defined before base::Value, since base::Value has a std::variant field that holds, among other things, a base::DictValue. Instead, just move the definition of the problematic templated constructor below the complete definition of base::Value. Bug: 388068055 Change-Id: I0c4c0d672c1a37d435ceabebbc2dab8df9cadf1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6664077 Reviewed-by: Lei Zhang <[email protected]> Commit-Queue: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/main@{#1478076}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.