Google Git
Sign in
chromium / chromium / src.git / ccca617ae78979e6f2909aa25b2bda88622880ea
commitccca617ae78979e6f2909aa25b2bda88622880ea[log] [tgz]
authorKevin McNee <[email protected]>Tue Oct 19 17:11:14 2021
committerChromium LUCI CQ <[email protected]>Tue Oct 19 17:11:14 2021
tree73d6a7e78fc293aac4fec952b6b250d1cf257f23
parent63ada6bca97c93239f31ca47022653ff55d35bc9 [diff]
Return the navigation created by LoadPostCommitErrorPage

SafeBrowsing code currently relies on a tab helper to listen for the
LoadPostCommitErrorPage navigations that it starts for subresource
triggered interstitials. This kind of navigation "user data" pattern
where callers need to rely on navigation observers to associate state
with the navigation they just started is cumbersome and additionally
needs to distinguish between the navigation it started and unrelated
navigations triggered by other sources.

We refactor this to now just return the NavigationHandle directly.

Bug: 1230802, 1077016
Change-Id: Ie512a854232fbfcb80986ea1e99eaab61d42a7d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3035445
Commit-Queue: Kevin McNee <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Daniel Rubery <[email protected]>
Reviewed-by: Carlos IL <[email protected]>
Cr-Commit-Position: refs/heads/main@{#933059}
15 files changed
tree: 73d6a7e78fc293aac4fec952b6b250d1cf257f23
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.