| commit | d1a2bfde021c2bc6500bd2ef11b4e7e786840149 | [log] [tgz] |
|---|---|---|
| author | François Doray <[email protected]> | Fri Jun 20 00:39:30 2025 |
| committer | Chromium LUCI CQ <[email protected]> | Fri Jun 20 00:39:30 2025 |
| tree | 1f841cf79588c519b5821d64e3e0a0842b8b4154 | |
| parent | 1976c3f0f3ff198800d4ecd9908011d9e039a553 [diff] |
[base] Avoid heap allocation when running/cancelling a cancellable delayed task. The flag allocated from: Task::WillRunTask DelayedTaskHandleDelegate::WillRunTask base::WeakPtrFactory::InvalidateWeakPtrs base::WeakReferenceOwner::Invalidate Is a top source of heap allocations, by count (not size). Motivated by previous work which improved Chrome speed by removing heap allocations, this CL introduces base::WeakPtrFactory::InvalidateWeakPtrsAndDoom, which clears the flag without creating a new one, and uses it in DelayedTaskHandleDelegate. Bug: 40897031 Change-Id: Ifb819ad304e04d548b37f1ddf3dc91f3caa7cae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6652889 Auto-Submit: Francois Pierre Doray <[email protected]> Commit-Queue: Francois Pierre Doray <[email protected]> Reviewed-by: Etienne Pierre-Doray <[email protected]> Cr-Commit-Position: refs/heads/main@{#1476314}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.