Google Git
Sign in
chromium / chromium / src.git / d5a8d0ba505809f5d8441a09d862dc9cf9b6ce71
commitd5a8d0ba505809f5d8441a09d862dc9cf9b6ce71[log] [tgz]
authorarthursonzogni <[email protected]>Thu Mar 11 17:36:43 2021
committerChromium LUCI CQ <[email protected]>Thu Mar 11 17:36:43 2021
treee8d0570101d9a819292bb0d289742c7ff968eae7
parent4a5a7acd307fc1d8a98de7f6e6817f460dd2fc7f [diff]
Reland "[OutOfBlinkSandbox] Remove blink computation.""

This reland 367718cbad4ce4b5286d5493bd1720ef5626cc4d.
https://chromium-review.googlesource.com/c/chromium/src/+/2450093

This is a pure reland (+ fix merge conflict). No substantial changes.

There was two causes of the revert:
(1) Synchronous about:blank not initiated by the creator of a
frame/window:
https://docs.google.com/document/d/1KY0DCaoKjUPbOX28N9KWvBjbnAfQEIRTaLbZUq9EkK8
This is now prevented by:
https://chromium-review.googlesource.com/c/chromium/src/+/2667151

(2) Missing sandbox from CSP inherited from the initiator.
The patch is now using PolicyContainer to get it correctly:
https://chromium-review.googlesource.com/c/chromium/src/+/2741581

---

Both causes have a regression tests. They were added by:
https://chromium-review.googlesource.com/c/chromium/src/+/2648117

[email protected],[email protected]

Bug: 1041376
Change-Id: Icf8a6123c41d3f80c72ddc9c24e2b9c5f76ebc43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2741587
Reviewed-by: Arthur Sonzogni <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Commit-Queue: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#862021}
22 files changed
tree: e8d0570101d9a819292bb0d289742c7ff968eae7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.