| commit | d836aa411b373888a2670f11fedd35b904cdb6a3 | [log] [tgz] |
|---|---|---|
| author | Alex Gough <[email protected]> | Mon Jul 15 23:56:52 2024 |
| committer | Chromium LUCI CQ <[email protected]> | Mon Jul 15 23:56:52 2024 |
| tree | 73459126fe496939c0fa396d1839ae9d6df3dd9a | |
| parent | 839742aefb6f0f737f086fe8ca3e0cca64065ccb [diff] |
Turn iterator _!=_.end() DCHECK() into CHECK() for content/browser
Accessing an invalid iterator can sometimes be a security
issue and these checks are cheap, so upgrade to CHECKs.
Generally these DCHECKS precede a use or erase of the
checked iterator, which if the check is invalid (ie. the
iterator == .end()) is UB.
Added checks are NotFatalUntil::M130.
`base/not_fatal_until.h` is added using tools/add_header.py,
this may result in some main-file (foo.h for foo.cc) headers
being re-sorted to be first as part `git cl format` of this CL.
For this CL instances were located with a weggli query:
```
weggli --verbose=1 --cpp \
'DCHECK(_ != _.end());' \
-p 'DCHECK(_.end() != _);' \
-p 'DCHECK_NE(_, _.end());' \
-p 'DCHECK_NE(_.end(), _);'
```
which should avoid any potentially expensive calculations
of the thing to be matched against .end().
This CL was uploaded by git cl split.
[email protected], [email protected], [email protected], [email protected], [email protected]
Bug: 351745839
Change-Id: Ic4b66209052fde03394b9f34241ae2bd9173ed7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5706540
Commit-Queue: Jinsuk Kim <[email protected]>
Reviewed-by: Peter Beverloo <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Jinsuk Kim <[email protected]>
Auto-Submit: Alex Gough <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1327876}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.