| commit | d977df34bcf396c93ccf36e1da0a00d02178a621 | [log] [tgz] |
|---|---|---|
| author | Rasika Navarange <[email protected]> | Wed Jun 05 10:01:27 2024 |
| committer | Chromium LUCI CQ <[email protected]> | Wed Jun 05 10:01:27 2024 |
| tree | a8f4673de654ab163ea006e5cc71b0d88bdb94ae | |
| parent | e76e3547d43e2fac02b3a4da9ef16ac3bc98294a [diff] [blame] |
[Chrome Stdlib] Fix presubmit A test data file was uploaded without adding a DEPS entry. The presubmit was only showing a message rather than an error. This change adds the missing DEPS entry and makes the presubmit message an error. Change-Id: I0491104ddf9ab0c9a84de1a7542354c198ab36f3 Bug: 345023320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5600600 Reviewed-by: Bret Sepulveda <[email protected]> Owners-Override: Bret Sepulveda <[email protected]> Commit-Queue: Rasika Navarange <[email protected]> Cr-Commit-Position: refs/heads/main@{#1310513}
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 9ce0829..7a7ce18d 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py
@@ -3434,7 +3434,7 @@ old_deps_entry = old_deps['src/base/tracing/test/data'] if not deps_entry: # TODO(312895063):Add back error when .sha256 files have been moved. - return [output_api.PresubmitNotifyResult( + return [output_api.PresubmitError( 'You must update the DEPS file when you update a ' '.sha256 file in base/tracing/test/data_sha256' )]