[StorageKey Cleanup] (3) Rename CreateWithNonce constructors
There's a need to keep StorageKey and BlinkStorageKey partial sync, but
as each organically grew this has gotten lost. As we wrap up and launch
storage partitioning, we should leave this code in a good state.
This CL migrates production StorageKey creation to use the re-named
CreateWithNonce function. There's no reason for this to be test only as
it allows simplification of the construction path.
This CL is part of a series:
(1) Organize public functions and map work
(2) Rename CreateFirstParty constructors
(3) Rename CreateWithNonce constructors
(4) Rename Create constructors
(5) Remove old test constructors
(6) Define opaque origin behavior
Bug: 1410254
Change-Id: Ibf7a1d5c6c3477dd18b1221e767cb9d1971f8c0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4252060
Commit-Queue: Daniel Cheng <[email protected]>
Auto-Submit: Ari Chivukula <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Owners-Override: Daniel Cheng <[email protected]>
Commit-Queue: Ari Chivukula <[email protected]>
Reviewed-by: Steven Bingler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1105940}
diff --git a/content/browser/renderer_host/navigation_request_unittest.cc b/content/browser/renderer_host/navigation_request_unittest.cc
index 01116fa..a55d2871 100644
--- a/content/browser/renderer_host/navigation_request_unittest.cc
+++ b/content/browser/renderer_host/navigation_request_unittest.cc
@@ -705,7 +705,7 @@
child_document =
static_cast<TestRenderFrameHost*>(navigation->GetFinalRenderFrameHost());
EXPECT_TRUE(child_document->IsCredentialless());
- EXPECT_EQ(blink::StorageKey::CreateWithNonceForTesting(
+ EXPECT_EQ(blink::StorageKey::CreateWithNonce(
url::Origin::Create(kUrl),
child_document->GetMainFrame()->credentialless_iframes_nonce()),
child_document->storage_key());
