| commit | e2d31314816212fc14aa7ee2b00585a5082e6603 | [log] [tgz] |
|---|---|---|
| author | Rakina Zata Amni <[email protected]> | Fri Nov 18 03:38:45 2022 |
| committer | Chromium LUCI CQ <[email protected]> | Fri Nov 18 03:38:45 2022 |
| tree | 1179e381160ed1f8f54851e15c3b63d800d217f8 | |
| parent | de441ff867d4dc8eb3a567efad6f0ad6664bfac7 [diff] |
Remove nullchecks for NavigationController::GetLastCommittedEntry() etc NavigationController's GetLastCommittedEntry(), GetVisibleEntry() and related functions used to be able to return nullptr when no navigation had committed. However, with InitialNavigationEntry enabled, those NavigationControllers would have at least 1 NavigationEntry, the initial NavigationEntry, and those functions will not return nullptr. This CL updates documentation for those functions and removes code that handles the null case, as they are not needed anymore. Bug: 524208 Change-Id: Ifcc1f6569ebe50c68021cb7338bad438b0b62fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3995872 Reviewed-by: Istiaque Ahmed <[email protected]> Reviewed-by: Wez <[email protected]> Reviewed-by: Charlie Reis <[email protected]> Reviewed-by: Andrey Kosyakov <[email protected]> Reviewed-by: Emily Stark <[email protected]> Reviewed-by: Basia Zimirska <[email protected]> Reviewed-by: Daniel Rubery <[email protected]> Reviewed-by: Clark DuVall <[email protected]> Commit-Queue: Rakina Zata Amni <[email protected]> Reviewed-by: Scott Violet <[email protected]> Reviewed-by: Olesia Marukhno <[email protected]> Reviewed-by: Nate Fischer <[email protected]> Cr-Commit-Position: refs/heads/main@{#1073193}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.