| commit | e7db1e3f3da734dc1baebac6b45b924136106d63 | [log] [tgz] |
|---|---|---|
| author | danakj <[email protected]> | Tue Apr 16 20:43:24 2024 |
| committer | Chromium LUCI CQ <[email protected]> | Tue Apr 16 20:43:24 2024 |
| tree | baeef2b675e5fd0d94f99c4f97dbf886f701402d | |
| parent | e0bd410bccd9f452c337ef22235851b7332540b6 [diff] |
Next generation control of unsafe-buffers-usage plugin Allow per-file control of warnings without clobbering the whole build. Do this in a way that allows us to mark all dirty files in individual directories incrementally, then work to remove those markings. Default to checking all source files except: * generated files * system headers Opt paths out of being checked by putting them in the paths file with a `-` at the start of the line: ``` -not_checked/ ``` Opt paths into being checked (overriding the above) by putting them in the paths file with a `+` at the start of the line: ``` +not_checked/actually_checked_though/ ``` Individual files can be opted in/out of checks without clobbering the whole build by using pragmas, which can appear anywhere in the file and will apply to the whole file, but not get applied to other files that include it or are included into it. To opt a file out of checks: ``` // TODO: crbug.com/XYZ - Remove unsafe pointer usage in this file. #pragma allow_unsafe_buffers ``` To opt a file into checks: ``` #pragma check_unsafe_buffers ``` Bug: 41497066, 40284755 Change-Id: Iefc06aaebc77b2a70c087975f77822fb5a8025f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5426599 Commit-Queue: danakj <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/main@{#1288287}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.