commit | ea99ea1dc01c5bbf058c18abe50008147e5b7ae9 | [log] [tgz] |
---|---|---|
author | clamy <[email protected]> | Mon May 28 13:54:23 2018 |
committer | Commit Bot <[email protected]> | Mon May 28 13:54:23 2018 |
tree | 14d733a30c842f9d1d7f516de19f2cbb41c7493b | |
parent | 6cf25da95bee042ec69811e16116fdadb0ea600d [diff] |
Move NavigationRequest creation to NavigationController: 2/3 This CL moves the NavigationRequest creation to the NavigationController. The Navigator will now take a NavigationRequest as an argument to Navigate instead of the pending NavigationEntry. Summary of the changes: 1) Navigator - NavigatorImpl::NavigateToEntry and NavigatorImpl::NavigateToPendingEntry are removed in favor of Navigate which takes as argument a NavigationRequest. The NavigationController is now responsible for creating the NavigationRequest and passing it to Navigator::Navigate to have the navigation start. - NavigatorImpl::RequestNavigation, which currently creates the NavigationRequest is removed. Instead, the NavigationRequest is created in NavigationControllerImpl::CreateNavigationRequest. 2) NavigationController - HandleRendererDebugURL is called from NavigateWithoutEntry and handles navigation to a renderer debug URL. Navigations to a renderer debug URL do not require a NavigationRequest. They cannot commit, hence why we can't have a committed NavigationEntry for a renderer debug URL. The next CLs will cleanup the internals of NavigationController. Bug: 803365 Change-Id: I8b01384324ccfdca451baf1e645ac7d0869e8d47 Reviewed-on: https://chromium-review.googlesource.com/957735 Commit-Queue: Camille Lamy <[email protected]> Reviewed-by: Charlie Reis <[email protected]> Cr-Commit-Position: refs/heads/master@{#562250}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .