| commit | eaf15532cf366b9fdd06cf6b18c4b2ff255b98a0 | [log] [tgz] |
|---|---|---|
| author | Wez <[email protected]> | Fri Nov 15 22:00:31 2019 |
| committer | Commit Bot <[email protected]> | Fri Nov 15 22:00:31 2019 |
| tree | fa4b0b02e5abb3b77471ad26e2178925b3b47cc4 | |
| parent | b65b28af36f986894c92c26ef8ebd01aeb26ad66 [diff] [blame] |
[base] Skip OutputToStream checks in Fuchsia Official builds. StackTrace has a bug preventing it from capturing any stack frames in Fuchsia Official builds, so disable those checks for now. TBR=ajwong Bug: 1025329, 1025288 Change-Id: I2b24c7f903c345518835edc3226b15355ea1bf9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919735 Reviewed-by: Wez <[email protected]> Reviewed-by: Kevin Marshall <[email protected]> Commit-Queue: Wez <[email protected]> Auto-Submit: Wez <[email protected]> Cr-Commit-Position: refs/heads/master@{#715875}
diff --git a/base/debug/stack_trace_unittest.cc b/base/debug/stack_trace_unittest.cc index b49a85b..96b18e23 100644 --- a/base/debug/stack_trace_unittest.cc +++ b/base/debug/stack_trace_unittest.cc
@@ -56,6 +56,12 @@ return; #endif // defined(OFFICIAL_BUILD) && defined(OS_POSIX) && !defined(OS_MACOSX) +#if defined(OFFICIAL_BUILD) && defined(OS_FUCHSIA) + // TODO(https://crbug.com/1025329): StackTrace fails to capture any frames in + // Fuchsia Official builds. + return; +#endif // defined(OFFICIAL_BUILD) && defined(OS_FUCHSIA) + ASSERT_TRUE(addresses); ASSERT_GT(frames_found, 5u) << "Too few frames found.";