Google Git
Sign in
chromium / chromium / src.git / fc4cc3d4a16b0dbd0b5d9628e6017b4cac9fecb3
commitfc4cc3d4a16b0dbd0b5d9628e6017b4cac9fecb3[log] [tgz]
authorRakina Zata Amni <[email protected]>Thu Jun 10 09:03:56 2021
committerChromium LUCI CQ <[email protected]>Thu Jun 10 09:03:56 2021
tree8bc76f6f5a17494cc892be472c1af2e42477baa4
parent13054029dceb8c53f50f91b0ae2f7d07cfb4f820 [diff]
Track initial empty document state separately of has_committed_real_load

crrev.com/c/2920136 made has_committed_real_load() return true if a
document.open() happens even when the frame hasn't committed a
non-about:blank document, to more closely track whether the frame is
still showing the initial empty document or not. This makes navigations
that happen after document.open() to trigger COOP BCG swaps in some
cases, breaking some websites (see crbug.com/1216244).

This CL reverts the behavior of has_committed_real_load() and instead
tracks the "initial empty document" state separately of
has_committed_real_load in FrameTreeNode, to be used for session history
purposes (e.g. determining if navigations should do replacement or not).

In the future, we'll migrate most usages of has_committed_real_load()
to check for "initial empty document" state instead as it is what is
used in the specification (there's nothing in the spec that tracks
has_committed_real_load).

Bug: 1216244, 1046898
Change-Id: I0f5e78db1034ae0b5ef306d26e06137cd2349330
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2944357
Auto-Submit: Rakina Zata Amni <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Commit-Queue: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#891146}
9 files changed
tree: 8bc76f6f5a17494cc892be472c1af2e42477baa4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.