Google Git
Sign in
chromium / chromium / src / 58d0dac03ef2c5361f522ae29b7f65d9a92e7de4
commit58d0dac03ef2c5361f522ae29b7f65d9a92e7de4[log] [tgz]
authorLukasz Anforowicz <[email protected]>Fri Mar 23 15:48:10 2018
committerCommit Bot <[email protected]>Fri Mar 23 15:48:10 2018
tree86f880d97d9714cba3787365c08a3746c8e1ca8d
parent4f44caa1b4678e6a149953c156b004f1becc4a20 [diff]
Call NotifyWillBeDestroyed before destroying TestBrowserContext.

Planned modifications to SpareRenderProcessHostManager (see
https://crrev.com/c/963405) require making sure that
BrowserContext::NotifyWillBeDestroyed is called before destroying the
context - otherwise some RenderProcessHost(s) (e.g. the spare one) can
survive longer than a BrowserContext leading to UaF when the
RenderProcessHost(s) are eventually destroyed later (potentially in a
different unit test :-).

This CL makes sure that NotifyWillBeDestroyed will be called from the
destructor of TestBrowserContext (and from a few other subclasses of
BrowserContext as appropriate).

Destroying the BrowserContext expands the scope of the requirement to
properly emulate browser threads in the tests by using
TestBrowserThreadBundle in a few more places.

Bug: 808114
Change-Id: I60b959e4969c39bededd6de7a3a51a8fdf12e387
Tbr: [email protected]
Tbr: [email protected]
Tbr: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/964804
Commit-Queue: Łukasz Anforowicz <[email protected]>
Reviewed-by: Sami Kyöstilä <[email protected]>
Reviewed-by: Sergey Volk <[email protected]>
Reviewed-by: Istiaque Ahmed <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#545463}
56 files changed
tree: 86f880d97d9714cba3787365c08a3746c8e1ca8d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_cleaner/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. notification_helper/
  38. pdf/
  39. ppapi/
  40. printing/
  41. remoting/
  42. rlz/
  43. sandbox/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .