Google Git
Sign in
chromium / chromium / src / 696c580f0823e050bc2f0355d777ebffa17d6ee2
commit696c580f0823e050bc2f0355d777ebffa17d6ee2[log] [tgz]
authorJeremy Roman <[email protected]>Fri Mar 31 17:15:18 2023
committerChromium LUCI CQ <[email protected]>Fri Mar 31 17:15:18 2023
tree284699812e67902b76ca1937ea89def0fda5fcff
parent433dfbae8335189f86cc4284f7331d4cada00e8f [diff]
Revert "[AX-Unserialize] Implement alternative Unserialize approach for AXTree"

This reverts commit 44aeb1ea1d5326196dabbb839c5db5a04ac521c3.

Reason for revert: AXTreeTest.UnserializePerformance is failing on Mac 10.15:
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/36703/overview

Original change's description:
> [AX-Unserialize] Implement alternative Unserialize approach for AXTree
>
> This CL switches the order of iterations for the AXTree's
> Unserialize method. Profiling suggested that by turning our
> loops "inside-out", we could improve performance. The idea
> being that it is easier to iterate over the node data and
> IDs than it is over the AXTreeObservers. Local testing has
> showed promising results.
>
> We add this implementation behind the feature flag added in
> the previous CL, and include a unit test for confidence.
>
>
> AX-Relnotes: N/A
> Bug: 1429305
> Change-Id: I1b9c6c2027d387ed39361046246210f4087c6d10
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4368188
> Reviewed-by: Aaron Leventhal <[email protected]>
> Reviewed-by: Andrew Grieve <[email protected]>
> Commit-Queue: Mark Schillaci <[email protected]>
> Reviewed-by: David Tseng <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1124736}

Bug: 1429305
Change-Id: Id6f3550f0af515968cfb14b3c3d1a44647c3a350
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4388966
Owners-Override: Jeremy Roman <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Jeremy Roman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1124791}
3 files changed
tree: 284699812e67902b76ca1937ea89def0fda5fcff
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.