Google Git
Sign in
chromium / chromium / src / 73c4cd465674f3c52f366708629ddb037b07537e
commit73c4cd465674f3c52f366708629ddb037b07537e[log] [tgz]
authorGarrett Beaty <[email protected]>Fri Oct 04 17:55:08 2024
committerChromium LUCI CQ <[email protected]>Fri Oct 04 17:55:08 2024
tree2f052cd26a98d661578c62ede2fb089cc8a45757
parent791c8488d5036c772aae44d4069c24b9f1965370 [diff]
Apply mixins from a matrix config even if no variants are specified.

The targets.legacy_matrix_config declaration does not require that any
variants are specified, but in that case the matrix config ends up being
entirely ignored: the basic suite is expanded without any variants and
without incorporating any mixins that are specified in the matrix
config. This behavior is surprising, so this changes it so that the
mixins will be applied to the non-variant expansion of the test in the
basic suite.

Bug: 371449681
Change-Id: I3a2ba7783220ccb22d45665ab0066d58a0eb3a38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5909979
Reviewed-by: Marco Georgaklis <[email protected]>
Reviewed-by: Struan Shrimpton <[email protected]>
Commit-Queue: Garrett Beaty <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1364329}
2 files changed
tree: 2f052cd26a98d661578c62ede2fb089cc8a45757
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.