Remove ppport.h's broken re-implementation of eval_pv().
authorTom Lane <[email protected]>
Wed, 9 Feb 2022 00:25:56 +0000 (19:25 -0500)
committerTom Lane <[email protected]>
Wed, 9 Feb 2022 00:26:30 +0000 (19:26 -0500)
commit1a8b6f055567b553376bb6b9e295379b613baeea
tree8d8a50ad685d859fa01111dae557731e372f0b58
parentfa362d2b3bde0f99ba8a22486205de11b2e00e14
Remove ppport.h's broken re-implementation of eval_pv().

Recent versions of Devel::PPPort try to redefine eval_pv() to
dodge a bug in pre-5.31 Perl versions.  Unfortunately the redefinition
fails on compilers that don't support statements nested within
expressions.  However, we aren't actually interested in this bug fix,
since we always call eval_pv() with croak_on_error = FALSE.
So, until there's an upstream fix for this breakage, just comment
out the macro to revert to the older behavior.

Per report from Wei Sun, as well as previous buildfarm failure
on pademelon (which I'd unfortunately not looked at carefully
enough to understand the cause).  Back-patch to all supported
versions, since we're using the same ppport.h in all.

Discussion: https://postgr.es/m/[email protected]
Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pademelon&dt=2022-02-02%2001%3A22%3A58
src/pl/plperl/ppport.h