Don't allow to set replication slot_name as ''.
authorAmit Kapila <akapila@postgresql.org>
Mon, 19 Jul 2021 06:02:08 +0000 (11:32 +0530)
committerAmit Kapila <akapila@postgresql.org>
Mon, 19 Jul 2021 06:02:08 +0000 (11:32 +0530)
commit22fd784afda38017137d88d75bfd5d91743cac19
treea2fce5e737bda40634aca1278ea0d7937f6c191b
parente8321a3190bd491af7c67c1a73d8c043a216ec25
Don't allow to set replication slot_name as ''.

We don't allow to create replication slot_name as an empty string ('') via
SQL API pg_create_logical_replication_slot() but it is allowed to be set
via Alter Subscription command. This will lead to apply worker repeatedly
keep trying to stream data via slot_name '' and the user is not allowed to
create the slot with that name.

Author: Japin Li
Reviewed-By: Ranier Vilela, Amit Kapila
Backpatch-through: 10, where it was introduced
Discussion: https://postgr.es/m/MEYP282MB1669CBD98E721C77CA696499B61A9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
src/backend/commands/subscriptioncmds.c
src/test/regress/expected/subscription.out
src/test/regress/sql/subscription.sql