Revert "Allow parallel workers to cope with a newly-created session user ID."
authorTom Lane <[email protected]>
Thu, 1 Aug 2024 00:56:11 +0000 (20:56 -0400)
committerTom Lane <[email protected]>
Thu, 1 Aug 2024 00:56:11 +0000 (20:56 -0400)
commit33c5baff66bd90c96a4ce8da4884d2c0c2b0eb35
treeea5ec20f234ddd48901b8c49f63d7b5875f056ef
parent216201027d90e99a0a2b2d2efba85dc0aac94c62
Revert "Allow parallel workers to cope with a newly-created session user ID."

This reverts commit 216201027d90e99a0a2b2d2efba85dc0aac94c62.

Some buildfarm animals are failing with "cannot change
"client_encoding" during a parallel operation".  It looks like
assign_client_encoding is unhappy at being asked to roll back a
client_encoding setting after a parallel worker encounters a
failure.  There must be more to it though: why didn't I see this
during local testing?  In any case, it's clear that moving the
RestoreGUCState() call is not as side-effect-free as I thought.
Given that the bug f5f30c22e intended to fix has gone unreported
for years, it's not something that's urgent to fix; I'm not
willing to risk messing with it further with only days to our
next release wrap.
src/backend/access/transam/parallel.c
src/backend/commands/variable.c
src/test/regress/expected/select_parallel.out
src/test/regress/sql/select_parallel.sql