pg_waldump: Fix --bkp-details to not issue spurious newlines for FPWs.
authorAndres Freund <[email protected]>
Wed, 30 Oct 2019 05:46:40 +0000 (22:46 -0700)
committerAndres Freund <[email protected]>
Wed, 30 Oct 2019 05:55:19 +0000 (22:55 -0700)
commit39ff656a415118cdd8231ee524aeed67796062a4
treeb80a4fb6c4bfb1be8ba2fc4a2a18613663ecea6b
parentc3882f8b894abd3a626272b4b58e114f3e282982
pg_waldump: Fix --bkp-details to not issue spurious newlines for FPWs.

The additional newline seems to have accidentally been introduced in
2c03216d831, in 9.5. The newline is only issued when an FPW is
present for the block reference.

While there could be an argument that removing the newlines in the
back branches could cause a problem for somebody parsing the
pg_waldump output, the likelihood of that seems small enough. It seems
at least equally likely that the randomness of when newlines are
issued causes problems.

Author: Andres Freund
Discussion: https://postgr.es/m/20191029233341[email protected]
Backpatch: 9.5, like 2c03216d831.
src/bin/pg_xlogdump/pg_xlogdump.c