Fix breakage of get_ps_display() in the PS_USE_NONE case.
authorTom Lane <[email protected]>
Sun, 27 Mar 2022 16:57:46 +0000 (12:57 -0400)
committerTom Lane <[email protected]>
Sun, 27 Mar 2022 16:57:52 +0000 (12:57 -0400)
commit3f7a59c59b4873a3b39838401d590f9d030a3500
tree1fbe52a0e58404ebcf1739704b3807ef52226dd8
parent27d384441851fe28ced962665632f2d1b914f11b
Fix breakage of get_ps_display() in the PS_USE_NONE case.

Commit 8c6d30f21 caused this function to fail to set *displen
in the PS_USE_NONE code path.  If the variable's previous value
had been negative, that'd lead to a memory clobber at some call
sites.  We'd managed not to notice due to very thin test coverage
of such configurations, but this appears to explain buildfarm member
lorikeet's recent struggles.

Credit to Andrew Dunstan for spotting the problem.  Back-patch
to v13 where the bug was introduced.

Discussion: https://postgr.es/m/136102.1648320427@sss.pgh.pa.us
src/backend/utils/misc/ps_status.c