TAP tests: check for postmaster.pid anyway when "pg_ctl start" fails.
authorTom Lane <[email protected]>
Wed, 19 Jan 2022 21:29:09 +0000 (16:29 -0500)
committerTom Lane <[email protected]>
Wed, 19 Jan 2022 21:29:09 +0000 (16:29 -0500)
commit40756287ff1f6d34554a221ea90f70ef86e576a5
tree723da6190541e567b451986f31a99f8a8f57700b
parentcb91cb8aaccede6c0b4bde2be79742dfc4b996c0
TAP tests: check for postpid anyway when "pg_ctl start" fails.

"pg_ctl start" might start a new postmaster and then return failure
anyway, for example if PGCTLTIMEOUT is exceeded.  If there is a
postmaster there, it's still incumbent on us to shut it down at
script end, so check for the PID file even though we are about
to fail.

This has been broken all along, so back-patch to all supported branches.

Discussion: https://postgr.es/m/647439.1642622744@sss.pgh.pa.us
src/test/perl/PostgresNode.pm