Fix pgbench performance issue induced by commit af35fe501.
authorTom Lane <[email protected]>
Fri, 7 Feb 2025 18:41:43 +0000 (13:41 -0500)
committerTom Lane <[email protected]>
Fri, 7 Feb 2025 18:41:43 +0000 (13:41 -0500)
commit5addea71c7c7693ed9aa071e122038e2dd7011ab
tree4b7d60dd111e67fc80fcbf88b47267e82d2896b4
parent9f6ad2f43c2fd94cfca99bb178d4eb03754cdd9d
Fix pgbench performance issue induced by commit af35fe501.

Commit af35fe501 caused "pgbench -i" to emit a '\r' character
for each data row loaded (when stderr is a terminal).
That's effectively invisible on-screen, but it causes the
connected terminal program to consume a lot of cycles.
It's even worse if you're connected over ssh, as the data
then has to pass through the ssh tunnel.

Simplest fix is to move the added logic inside the if-tests
that check whether to print a progress line.  We could do
it another way that avoids duplicating these few lines,
but on the whole this seems the most transparent way to
write it.

Like the previous commit, back-patch to all supported versions.

Reported-by: Andres Freund <[email protected]>
Author: Tom Lane <[email protected]>
Reviewed-by: Nathan Bossart <[email protected]>
Discussion: https://postgr.es/m/4k4drkh7bcmdezq6zbkhp25mnrzpswqi2o75d5uv2eeg3aq6q7@b7kqdmzzwzgb
Backpatch-through: 13
src/bin/pgbench/pgbench.c