vacuumdb: Skip temporary tables in query to build list of relations
authorMichael Paquier <[email protected]>
Wed, 25 Sep 2024 05:44:57 +0000 (14:44 +0900)
committerMichael Paquier <[email protected]>
Wed, 25 Sep 2024 05:44:57 +0000 (14:44 +0900)
commit60c618216ddbfcd65fc6c8078c1dbb775643662b
tree68a51be27e65f9d84f87d6cf8ba5e48ac2e1b763
parentf51b34b3eddbc501063f7b8ac470d26ce4e18a48
vacuumdb: Skip temporary tables in query to build list of relations

Running vacuumdb with a non-superuser while another user has created a
temporary table would lead to a mid-flight permission failure,
interrupting the operation.  vacuum_rel() skips temporary relations of
other backends, and it makes no sense for vacuumdb to know about these
relations, so let's switch it to ignore temporary relations entirely.

Adding a qual in the query based on relpersistence simplifies the
generation of its WHERE clause in vacuum_one_database(), per se the
removal of "has_where".

Author: VaibhaveS, Michael Paquier
Reviewed-by: Fujii Masao
Discussion: https://postgr.es/m/CAM_eQjwfAR=y3G1fGyS1U9FTmc+FyJm9amNfY2QCZBnDDbNPZg@mail.gmail.com
Backpatch-through: 12
src/bin/scripts/vacuumdb.c