Fix wrong assertion and poor error messages in "COPY (query) TO".
authorTom Lane <[email protected]>
Mon, 21 Oct 2024 19:08:22 +0000 (15:08 -0400)
committerTom Lane <[email protected]>
Mon, 21 Oct 2024 19:08:22 +0000 (15:08 -0400)
commit6a57a457cf7d3409579868ef17de6725ec6e67ca
tree38bc1c2ff1c4002f701b3b25628a478b4006ec73
parente2ec3afebc238e281df7f3f435c243d9c300046d
Fix wrong assertion and poor error messages in "COPY (query) TO".

If the query is rewritten into a NOTIFY command by a DO INSTEAD
rule, we'd get an assertion failure, or in non-assert builds
issue a rather confusing error message.  Improve that.

Also fix a longstanding grammar mistake in a nearby error message.

Per bug #18664 from Alexander Lakhin.  Back-patch to all supported
branches.

Tender Wang and Tom Lane

Discussion: https://postgr.es/m/18664-ffd0ebc2386598df@postgresql.org
src/backend/commands/copy.c
src/test/regress/expected/copydml.out
src/test/regress/sql/copydml.sql