Move I/O before the index_update_stats() buffer lock region.
authorNoah Misch <[email protected]>
Sat, 2 Nov 2024 16:04:55 +0000 (09:04 -0700)
committerNoah Misch <[email protected]>
Sat, 2 Nov 2024 16:05:07 +0000 (09:05 -0700)
commit6b01cac0be6dd044fa3c2d08df7e893b96dfafe6
tree24a3f19969ceb1a5ed1dbfd135ca43967a5a2482
parentfe8091c9e39e65c8a0044349f0c0e7c3386ae921
Move I/O before the index_update_stats() buffer lock region.

Commit a07e03fd8fa7daf4d1356f7cb501ffe784ea6257 enlarged the work done
here under the pg_class heap buffer lock.  Two preexisting actions are
best done before holding that lock.  Both RelationGetNumberOfBlocks()
and visibilitymap_count() do I/O, and the latter might exclusive-lock a
visibility map buffer.  Moving these reduces contention and risk of
undetected LWLock deadlock.  Back-patch to v12, like that commit.

Discussion: https://postgr.es/m/20241031200139[email protected]
src/backend/catalog/index.c