Use --strip-unneeded when stripping static libraries with GNU strip.
authorTom Lane <[email protected]>
Thu, 20 Apr 2023 22:12:32 +0000 (18:12 -0400)
committerTom Lane <[email protected]>
Thu, 20 Apr 2023 22:12:32 +0000 (18:12 -0400)
commit6d60b718ceb09603eb26b6d6788b5c19c04ec5eb
tree4cd1ce2ce1ba32900160f597811e38262fda64e2
parentb79b36f269bb9d5da6e0d291f0827e1777603e4a
Use --strip-unneeded when stripping static libraries with GNU strip.

We've long used "--strip-unneeded" for shared libraries but plain
"-x" for static libraries when stripping symbols with GNU strip.
There doesn't seem to be any really good reason for that though,
since --strip-unneeded produces smaller output (as "-x" alone
does not remove debug symbols).  Moreover it seems that
llvm-strip, although it identifies as GNU strip, misbehaves when
given "-x" for this purpose.  It's unclear whether that's
intentional or a bug in llvm-strip, but in any case it seems like
changing to use --strip-unneeded in all cases should be a win.

Note that this doesn't change our behavior when dealing with
non-GNU strip.

Per gripes from Ed Maste and Palle Girgensohn.  Back-patch,
in case anyone wants to use llvm-strip with stable branches.

Discussion: https://postgr.es/m/17898-5308d09543463266@postgresql.org
Discussion: https://postgr.es/m/20230420153338[email protected]
config/programs.m4
configure