Fix determination of broken LSN in OVERWRITTEN_CONTRECORD
authorAlvaro Herrera <[email protected]>
Fri, 26 Nov 2021 14:14:27 +0000 (11:14 -0300)
committerAlvaro Herrera <[email protected]>
Fri, 26 Nov 2021 14:14:27 +0000 (11:14 -0300)
commit72cf39d51ade63954c868bfe93996b4be7a79bf5
treec47583bdd3d4966a58c25fbfbb78ff015fedfbca
parent4339e10f090ec6b5ceb727c00e7a345cc9178e1e
Fix determination of broken LSN in OVERWRITTEN_CONTRECORD

In commit ff9f111bce24 I mixed up inconsistent definitions of the LSN of
the first record in a page, when the previous record ends exactly at the
page boundary.  The correct LSN is adjusted to skip the WAL page header;
I failed to use that when setting XLogReaderState->overwrittenRecPtr,
so at WAL replay time VerifyOverwriteContrecord would refuse to let
replay continue past that record.

Backpatch to 10.  9.6 also contains this bug, but it's no longer being
maintained.

Discussion: https://postgr.es/m/45597.1637694259@sss.pgh.pa.us
src/backend/access/transam/xlogreader.c