Fix variable initialization when using buffering build with GiST
authorMichael Paquier <[email protected]>
Wed, 10 Jul 2019 06:15:29 +0000 (15:15 +0900)
committerMichael Paquier <[email protected]>
Wed, 10 Jul 2019 06:15:29 +0000 (15:15 +0900)
commit7b60468fa14ac8b65ba91f2dc3c2df11361d4be3
treeb636f631fc85504bfd931dc8fc988839261b36a5
parentd49c127d90f94579a13106d4e7b198d04e5eea88
Fix variable initialization when using buffering build with GiST

This can cause valgrind to complain, as the flag marking a buffer as a
temporary copy was not getting initialized.

While on it, fill in with zeros newly-created buffer pages.  This does
not matter when loading a block from a temporary file, but it makes the
push of an index tuple into a new buffer page safer.

This has been introduced by 1d27dcf, so backpatch all the way down to
9.4.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/15899-0d24fb273b3dd90c@postgresql.org
Backpatch-through: 9.4
src/backend/access/gist/gistbuildbuffers.c