Block ALTER TABLE .. DROP NOT NULL on columns in replica identity index
authorMichael Paquier <[email protected]>
Thu, 25 Nov 2021 06:05:37 +0000 (15:05 +0900)
committerMichael Paquier <[email protected]>
Thu, 25 Nov 2021 06:05:37 +0000 (15:05 +0900)
commit817c469c2a167518a7cb44a84c996c7d11a728e4
tree7ce56790ceb94b9d9cc5d0b1df7f16c3daf1c4ea
parent09c11134916c4fdae0bf557c02181e60e76b28ea
Block ALTER TABLE .. DROP NOT NULL on columns in replica identity index

Replica identities that depend directly on an index rely on a set of
properties, one of them being that all the columns defined in this index
have to be marked as NOT NULL.  There was a hole in the logic with ALTER
TABLE DROP NOT NULL, where it was possible to remove the NOT NULL
property of a column part of an index used as replica identity, so block
it to avoid problems with logical decoding down the road.

The same check was already done columns part of a primary key, so the
fix is straight-forward.

Author: Haiying Tang, Hou Zhijie
Reviewed-by: Dilip Kumar, Michael Paquier
Discussion: https://postgr.es/m/OS0PR01MB6113338C102BEE8B2FFC5BD9FB619@OS0PR01MB6113.jpnprd01.prod.outlook.com
Backpatch-through: 10
src/backend/commands/tablecmds.c
src/test/regress/expected/replica_identity.out
src/test/regress/sql/replica_identity.sql