Don't repeatedly register cache callbacks in pgoutput plugin.
authorTom Lane <[email protected]>
Thu, 23 Feb 2023 20:40:28 +0000 (15:40 -0500)
committerTom Lane <[email protected]>
Thu, 23 Feb 2023 20:40:28 +0000 (15:40 -0500)
commit861e9e48601b41ab3827ba5d22990c17ed6dcf8c
tree7e5a66f0b4027e36aa1080d097456940fb3b7ffc
parent226da3d4767083b58b9d1acf67b1402865d359bf
Don't repeatedly register cache callbacks in pgoutput plugin.

Multiple cycles of starting up and shutting down the plugin within a
single session would eventually lead to "out of relcache_callback_list
slots", because pgoutput_startup blindly re-registered its cache
callbacks each time.  Fix it to register them only once, as all other
users of cache callbacks already take care to do.

This has been broken all along, so back-patch to all supported branches.

Shi Yu

Discussion: https://postgr.es/m/OSZPR01MB631004A78D743D68921FFAD3FDA79@OSZPR01MB6310.jpnprd01.prod.outlook.com
src/backend/replication/pgoutput/pgoutput.c