Fix RelationIdGetRelation calls that weren't bothering with error checks.
authorTom Lane <[email protected]>
Sun, 8 Sep 2019 21:00:29 +0000 (17:00 -0400)
committerTom Lane <[email protected]>
Sun, 8 Sep 2019 21:00:57 +0000 (17:00 -0400)
commit87ee1587c94d04e8c91d9346cd632369bede586c
treef85be5f211e9e79993d4e9d2b009c9d9ca0f81ed
parent3c155bafa59b26e0bb38b8e70b9034183c946d39
Fix RelationIdGetRelation calls that weren't bothering with error checks.

Some of these are quite old, but that doesn't make them not bugs.
We'd rather report a failure via elog than SIGSEGV.

While at it, uniformly spell the error check as !RelationIsValid(rel)
rather than a bare rel == NULL test.  The machine code is the same
but it seems better to be consistent.

Coverity complained about this today, not sure why, because the
mistake is in fact old.
src/backend/access/heap/heapam.c
src/backend/replication/logical/reorderbuffer.c