Fix Y2038 issues with MyStartTime.
authorNathan Bossart <[email protected]>
Mon, 7 Oct 2024 18:51:03 +0000 (13:51 -0500)
committerNathan Bossart <[email protected]>
Mon, 7 Oct 2024 18:51:03 +0000 (13:51 -0500)
commit8aaf88b63de3d6e665b0fcf1ff123f08b961fe66
tree3255b1b8039139d94d35093b8f90b2989d792b1d
parent0f0e253dbf9ed60e037e9b90120404e385c8377b
Fix Y2038 issues with MyStartTime.

Several places treat MyStartTime as a "long", which is only 32 bits
wide on some platforms.  In reality, MyStartTime is a pg_time_t,
i.e., a signed 64-bit integer.  This will lead to interesting bugs
on the aforementioned systems in 2038 when signed 32-bit integers
are no longer sufficient to store Unix time (e.g., "pg_ctl start"
hanging).  To fix, ensure that MyStartTime is handled as a 64-bit
value everywhere.  (Of course, users will need to ensure that
time_t is 64 bits wide on their system, too.)

Co-authored-by: Max Johnson
Discussion: https://postgr.es/m/CO1PR07MB905262E8AC270FAAACED66008D682%40CO1PR07MB9052.namprd07.prod.outlook.com
Backpatch-through: 12
contrib/postgres_fdw/option.c
src/backend/utils/error/csvlog.c
src/backend/utils/error/elog.c
src/backend/utils/error/jsonlog.c
src/backend/utils/init/miscinit.c
src/bin/pg_ctl/pg_ctl.c