Fix MVCC bug with prepared xact with subxacts on standby
authorHeikki Linnakangas <[email protected]>
Thu, 27 Jun 2024 18:06:32 +0000 (21:06 +0300)
committerHeikki Linnakangas <[email protected]>
Thu, 27 Jun 2024 18:10:34 +0000 (21:10 +0300)
commit9dbf8ab48c21f9a006e578983b21739326d7c621
tree4141098290e16d0e6bd993e0ccbe14caac2c21e0
parent34221af648f1b5b2aaa5c1814e692ec98063ba52
Fix MVCC bug with prepared xact with subxacts on standby

We did not recover the subtransaction IDs of prepared transactions
when starting a hot standby from a shutdown checkpoint. As a result,
such subtransactions were considered as aborted, rather than
in-progress. That would lead to hint bits being set incorrectly, and
the subtransactions suddenly becoming visible to old snapshots when
the prepared transaction was committed.

To fix, update pg_subtrans with prepared transactions's subxids when
starting hot standby from a shutdown checkpoint. The snapshots taken
from that state need to be marked as "suboverflowed", so that we also
check the pg_subtrans.

Backport to all supported versions.

Discussion: https://www.postgresql.org/message-id/6b852e98-2d49-4ca1-9e95-db419a2696e0@iki.fi
src/backend/access/transam/twophase.c
src/backend/access/transam/xlog.c
src/backend/storage/ipc/procarray.c
src/backend/storage/ipc/standby.c
src/include/storage/standby.h
src/test/recovery/t/009_twophase.pl
src/tools/pgindent/typedefs.list