Lock table in DROP STATISTICS
authorTomas Vondra <tomas.vondra@postgresql.org>
Sun, 19 Nov 2023 20:03:29 +0000 (21:03 +0100)
committerTomas Vondra <tomas.vondra@postgresql.org>
Sun, 19 Nov 2023 20:04:28 +0000 (21:04 +0100)
commit9dd50e92ed239bc4643c1df7e9e0bcc03b05bfef
treec3770dd155c39459f533382112c812f32f3a21d5
parentfc3f862babd76f0ac4f372f9409f5129ccb2ee7e
Lock table in DROP STATISTICS

The DROP STATISTICS code failed to properly lock the table, leading to

  ERROR:  tuple concurrently deleted

when executed concurrently with ANALYZE.

Fixed by modifying RemoveStatisticsById() to acquire the same lock as
ANALYZE. This function is called only by DROP STATISTICS, as ANALYZE
calls RemoveStatisticsDataById() directly.

Reported by Justin Pryzby, fix by me. Backpatch through 12. The code was
like this since it was introduced in 10, but older releases are EOL.

Reported-by: Justin Pryzby
Reviewed-by: Tom Lane
Backpatch-through: 12

Discussion: https://postgr.es/m/ZUuk-8CfbYeq6g_u@pryzbyj2023
src/backend/commands/statscmds.c