Correct type of front_pathkey to PathKey
authorTomas Vondra <[email protected]>
Sun, 23 Jan 2022 02:36:55 +0000 (03:36 +0100)
committerTomas Vondra <[email protected]>
Sun, 23 Jan 2022 02:54:13 +0000 (03:54 +0100)
commita3eb08b809a4b9e348efb0bae9c2834b71d53273
treeb8cec8ad5e8f6d04f25c7295a71c52fc5ae4aac2
parent0c7c94f90cd4ee005fac84f30cb7ee5e0c96a835
Correct type of front_pathkey to PathKey

In sort_inner_and_outer we iterate a list of PathKey elements, but the
variable is declared as (List *). This mistake is benign, because we
only pass the pointer to lcons() and never dereference it.

This exists since ~2004, but it's confusing. So fix and backpatch to all
supported branches.

Backpatch-through: 10
Discussion: https://postgr.es/m/bf3a6ea1-a7d8-7211-0669-189d5c169374%40enterprisedb.com
src/backend/optimizer/path/joinpath.c