Avoid using ambiguous word "non-negative" in error messages.
authorFujii Masao <[email protected]>
Tue, 27 Jul 2021 16:25:53 +0000 (01:25 +0900)
committerFujii Masao <[email protected]>
Tue, 27 Jul 2021 16:25:53 +0000 (01:25 +0900)
commita84f95ffddbf9bfcf20f7e3b463e10ba1ec0b9f5
tree21f040b92c664314ee33627341118c0da7b35ad4
parent71121450e8f42b21665ee9c8f70b701f7a16c801
Avoid using ambiguous word "non-negative" in error messages.

The error messages using the word "non-negative" are confusing
because it's ambiguous about whether it accepts zero or not.
This commit improves those error messages by replacing it with
less ambiguous word like "greater than zero" or
"greater than or equal to zero".

Also this commit added the note about the word "non-negative" to
the error message style guide, to help writing the new error messages.

When postgres_fdw option fetch_size was set to zero, previously
the error message "fetch_size requires a non-negative integer value"
was reported. This error message was outright buggy. Therefore
back-patch to all supported versions where such buggy error message
could be thrown.

Reported-by: Hou Zhijie
Author: Bharath Rupireddy
Reviewed-by: Kyotaro Horiguchi, Fujii Masao
Discussion: https://postgr.es/m/OS0PR01MB5716415335A06B489F1B3A8194569@OS0PR01MB5716.jpnprd01.prod.outlook.com
contrib/postgres_fdw/option.c
doc/src/sgml/sources.sgml
src/backend/utils/adt/tsquery_op.c
src/test/modules/test_shm_mq/test.c