Handle DROP DATABASE getting interrupted
authorAndres Freund <[email protected]>
Thu, 13 Jul 2023 20:03:33 +0000 (13:03 -0700)
committerAndres Freund <[email protected]>
Thu, 13 Jul 2023 20:03:33 +0000 (13:03 -0700)
commitd11efe83038538a7b5169c679ceee457f5753877
tree8cad902b4c97a2931785d16a8e06f454fe021a0c
parente246fd42363fcfd61cb98fb338c307e52747973f
Handle DROP DATABASE getting interrupted

Until now, when DROP DATABASE got interrupted in the wrong moment, the removal
of the pg_database row would also roll back, even though some irreversible
steps have already been taken. E.g. DropDatabaseBuffers() might have thrown
out dirty buffers, or files could have been unlinked. But we continued to
allow connections to such a corrupted database.

To fix this, mark databases invalid with an in-place update, just before
starting to perform irreversible steps. As we can't add a new column in the
back branches, we use pg_database.datconnlimit = -2 for this purpose.

An invalid database cannot be connected to anymore, but can still be
dropped.

Unfortunately we can't easily add output to psql's \l to indicate that some
database is invalid, it doesn't fit in any of the existing columns.

Add tests verifying that a interrupted DROP DATABASE is handled correctly in
the backend and in various tools.

Reported-by: Evgeny Morozov <[email protected]>
Author: Andres Freund <[email protected]>
Reviewed-by: Daniel Gustafsson <[email protected]>
Reviewed-by: Thomas Munro <[email protected]>
Discussion: https://postgr.es/m/20230509004637[email protected]
Discussion: https://postgr.es/m/20230314174521[email protected]
Backpatch: 11-, bug present in all supported versions
18 files changed:
doc/src/sgml/catalogs.sgml
src/backend/commands/dbcommands.c
src/backend/commands/vacuum.c
src/backend/postmaster/autovacuum.c
src/backend/utils/init/postinit.c
src/bin/pg_amcheck/pg_amcheck.c
src/bin/pg_amcheck/t/002_nonesuch.pl
src/bin/pg_dump/pg_dumpall.c
src/bin/pg_dump/t/002_pg_dump.pl
src/bin/scripts/clusterdb.c
src/bin/scripts/reindexdb.c
src/bin/scripts/t/011_clusterdb_all.pl
src/bin/scripts/t/050_dropdb.pl
src/bin/scripts/t/091_reindexdb_all.pl
src/bin/scripts/t/101_vacuumdb_all.pl
src/bin/scripts/vacuumdb.c
src/include/catalog/pg_database.h
src/test/recovery/t/037_invalid_database.pl [new file with mode: 0644]