Fix wrong logic in TransactionIdInRecentPast()
authorAlexander Korotkov <[email protected]>
Thu, 8 Feb 2024 10:45:26 +0000 (12:45 +0200)
committerAlexander Korotkov <[email protected]>
Fri, 9 Feb 2024 10:55:43 +0000 (12:55 +0200)
commitd44060cfcc49d512da1ae9b1b846385748e46d04
treea8567941691831b3687ecd2f18143238e34f9523
parent3ba17930941ea629b2ffb5cd252f3055d4d4a9a6
Fix wrong logic in TransactionIdInRecentPast()

The TransactionIdInRecentPast() should return false for all the transactions
older than TransamVariables->oldestClogXid.  However, the function contains
a bug in comparison FullTransactionId to TransactionID allowing full
transactions between nextXid - 2^32 and oldestClogXid - 2^31.

This commit fixes TransactionIdInRecentPast() by turning the oldestClogXid into
FullTransactionId first, then performing the comparison.

Backpatch to all supported versions.

Reported-by: Egor Chindyaskin
Bug: 18212
Discussion: https://postgr.es/m/18212-547307f8adf57262%40postgresql.org
Author: Karina Litskevich
Reviewed-by: Kyotaro Horiguchi
Backpatch-through: 12
src/backend/utils/adt/txid.c