Fix MVCC bug with prepared xact with subxacts on standby
authorHeikki Linnakangas <[email protected]>
Thu, 27 Jun 2024 18:06:32 +0000 (21:06 +0300)
committerHeikki Linnakangas <[email protected]>
Thu, 27 Jun 2024 18:08:55 +0000 (21:08 +0300)
commite9c8747ee934db9b5bad0b0f5aa3709a41ad0a9c
treee6018ceb11c55499abd80b448b30642bcde1a7b1
parent071e19a36c68dd5f1d949ecf9f110f1ec95a9532
Fix MVCC bug with prepared xact with subxacts on standby

We did not recover the subtransaction IDs of prepared transactions
when starting a hot standby from a shutdown checkpoint. As a result,
such subtransactions were considered as aborted, rather than
in-progress. That would lead to hint bits being set incorrectly, and
the subtransactions suddenly becoming visible to old snapshots when
the prepared transaction was committed.

To fix, update pg_subtrans with prepared transactions's subxids when
starting hot standby from a shutdown checkpoint. The snapshots taken
from that state need to be marked as "suboverflowed", so that we also
check the pg_subtrans.

Backport to all supported versions.

Discussion: https://www.postgresql.org/message-id/6b852e98-2d49-4ca1-9e95-db419a2696e0@iki.fi
src/backend/access/transam/twophase.c
src/backend/access/transam/xlog.c
src/backend/storage/ipc/procarray.c
src/backend/storage/ipc/standby.c
src/include/storage/standby.h
src/test/recovery/t/009_twophase.pl
src/tools/pgindent/typedefs.list