Clean out column-level pg_init_privs entries when dropping tables.
authorTom Lane <[email protected]>
Fri, 14 Jun 2024 20:20:35 +0000 (16:20 -0400)
committerTom Lane <[email protected]>
Fri, 14 Jun 2024 20:20:35 +0000 (16:20 -0400)
commitf3f6a14ce3e982fb7fbe9f4f33134f3f693f4b7e
tree5d93e8da907a4249b0f6e3d425e3f338879065dc
parent5912bf77c526fdb8cfc9bbb56a509a152c6a3632
Clean out column-level pg_init_privs entries when dropping tables.

DeleteInitPrivs did not get the memo about how, when dropping a
whole object (with subid == 0), you should drop entries relating
to its sub-objects too.  This is visible in the test_pg_dump test
case if one drops the extension at the end: the entry for
GRANT SELECT(col1) ON regress_pg_dump_table TO public;
was still present in pg_init_privs afterwards, although it was
pointing to a dangling table OID.

Noted while fooling with a fix for REASSIGN OWNED for pg_init_privs
entries.  This bug is aboriginal in the pg_init_privs feature
though, and there seems no reason not to back-patch the fix.
src/backend/catalog/dependency.c
src/test/modules/test_pg_dump/expected/test_pg_dump.out
src/test/modules/test_pg_dump/sql/test_pg_dump.sql