Fix misbehavior with expression indexes on ON COMMIT DELETE ROWS tables.

We implement ON COMMIT DELETE ROWS by truncating tables marked that
way, which requires also truncating/rebuilding their indexes.  But
RelationTruncateIndexes asks the relcache for up-to-date copies of any
index expressions, which may cause execution of eval_const_expressions
on them, which can result in actual execution of subexpressions.
This is a bad thing to have happening during ON COMMIT.  Manuel Rigger
reported that use of a SQL function resulted in crashes due to
expectations that ActiveSnapshot would be set, which it isn't.
The most obvious fix perhaps would be to push a snapshot during
PreCommit_on_commit_actions, but I think that would just open the door
to more problems: CommitTransaction explicitly expects that no
user-defined code can be running at this point.

Fortunately, since we know that no tuples exist to be indexed, there
seems no need to use the real index expressions or predicates during
RelationTruncateIndexes.  We can set up dummy index expressions
instead (we do need something that will expose the right data type,
as there are places that build index tupdescs based on this), and
just ignore predicates and exclusion constraints.

In a green field it'd likely be better to reimplement ON COMMIT DELETE
ROWS using the same "init fork" infrastructure used for unlogged
relations.  That seems impractical without catalog changes though,
and even without that it'd be too big a change to back-patch.
So for now do it like this.

Per private report from Manuel Rigger.  This has been broken forever,
so back-patch to all supported branches.

diff --git a/src/backend/catalog/heap.c b/src/backend/catalog/heap.c
index 39ad95968fc59c1acdb7a66cf12dcd4ddf8cc7a2..3637d618e122b5b9ff0eedf15a3914686794e913 100644 (file)
--- a/src/backend/catalog/heap.c
+++ b/src/backend/catalog/heap.c
@@ -2709,8 +2709,15 @@ RelationTruncateIndexes(Relation heapRelation)
        /* Open the index relation; use exclusive lock, just to be sure */
        currentIndex = index_open(indexId, AccessExclusiveLock);
 
-       /* Fetch info needed for index_build */
-       indexInfo = BuildIndexInfo(currentIndex);
+       /*
+        * Fetch info needed for index_build.  Since we know there are no
+        * tuples that actually need indexing, we can use a dummy IndexInfo.
+        * This is slightly cheaper to build, but the real point is to avoid
+        * possibly running user-defined code in index expressions or
+        * predicates.  We might be getting invoked during ON COMMIT
+        * processing, and we don't want to run any such code then.
+        */
+       indexInfo = BuildDummyIndexInfo(currentIndex);
 
        /*
         * Now truncate the actual file (and discard buffers).

diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c
index 8cddef328472efbf73f40c86818f9730195a7110..e9df990962cb31e63f8b3f7f2b155f41d5da8470 100644 (file)
--- a/src/backend/catalog/index.c
+++ b/src/backend/catalog/index.c
@@ -1660,6 +1660,61 @@ BuildIndexInfo(Relation index)
    return ii;
 }
 
+/* ----------------
+ *     BuildDummyIndexInfo
+ *         Construct a dummy IndexInfo record for an open index
+ *
+ * This differs from the real BuildIndexInfo in that it will never run any
+ * user-defined code that might exist in index expressions or predicates.
+ * Instead of the real index expressions, we return null constants that have
+ * the right types/typmods/collations.  Predicates and exclusion clauses are
+ * just ignored.  This is sufficient for the purpose of truncating an index,
+ * since we will not need to actually evaluate the expressions or predicates;
+ * the only thing that's likely to be done with the data is construction of
+ * a tupdesc describing the index's rowtype.
+ * ----------------
+ */
+IndexInfo *
+BuildDummyIndexInfo(Relation index)
+{
+   IndexInfo  *ii = makeNode(IndexInfo);
+   Form_pg_index indexStruct = index->rd_index;
+   int         i;
+   int         numKeys;
+
+   /* check the number of keys, and copy attr numbers into the IndexInfo */
+   numKeys = indexStruct->indnatts;
+   if (numKeys < 1 || numKeys > INDEX_MAX_KEYS)
+       elog(ERROR, "invalid indnatts %d for index %u",
+            numKeys, RelationGetRelid(index));
+   ii->ii_NumIndexAttrs = numKeys;
+   for (i = 0; i < numKeys; i++)
+       ii->ii_KeyAttrNumbers[i] = indexStruct->indkey.values[i];
+
+   /* fetch dummy expressions for expressional indexes */
+   ii->ii_Expressions = RelationGetDummyIndexExpressions(index);
+   ii->ii_ExpressionsState = NIL;
+
+   /* pretend there is no predicate */
+   ii->ii_Predicate = NIL;
+   ii->ii_PredicateState = NULL;
+
+   /* We ignore the exclusion constraint if any */
+   ii->ii_ExclusionOps = NULL;
+   ii->ii_ExclusionProcs = NULL;
+   ii->ii_ExclusionStrats = NULL;
+
+   /* other info */
+   ii->ii_Unique = indexStruct->indisunique;
+   ii->ii_ReadyForInserts = IndexIsReady(indexStruct);
+
+   /* initialize index-build state to default */
+   ii->ii_Concurrent = false;
+   ii->ii_BrokenHotChain = false;
+
+   return ii;
+}
+
 /* ----------------
  *     FormIndexDatum
  *         Construct values[] and isnull[] arrays for a new index tuple.

diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
index bdfad491c47abe9a8b4d6c9d63046991c41c4356..e64b00c471981aea9b48e985f6d50c5cc5b1ff34 100644 (file)
--- a/src/backend/utils/cache/relcache.c
+++ b/src/backend/utils/cache/relcache.c
@@ -56,6 +56,8 @@
 #include "catalog/storage.h"
 #include "commands/trigger.h"
 #include "miscadmin.h"
+#include "nodes/makefuncs.h"
+#include "nodes/nodeFuncs.h"
 #include "optimizer/clauses.h"
 #include "optimizer/planmain.h"
 #include "optimizer/prep.h"
@@ -4068,6 +4070,57 @@ RelationGetIndexExpressions(Relation relation)
    return result;
 }
 
+/*
+ * RelationGetDummyIndexExpressions -- get dummy expressions for an index
+ *
+ * Return a list of dummy expressions (just Const nodes) with the same
+ * types/typmods/collations as the index's real expressions.  This is
+ * useful in situations where we don't want to run any user-defined code.
+ */
+List *
+RelationGetDummyIndexExpressions(Relation relation)
+{
+   List       *result;
+   Datum       exprsDatum;
+   bool        isnull;
+   char       *exprsString;
+   List       *rawExprs;
+   ListCell   *lc;
+
+   /* Quick exit if there is nothing to do. */
+   if (relation->rd_indextuple == NULL ||
+       heap_attisnull(relation->rd_indextuple, Anum_pg_index_indexprs))
+       return NIL;
+
+   /* Extract raw node tree(s) from index tuple. */
+   exprsDatum = heap_getattr(relation->rd_indextuple,
+                             Anum_pg_index_indexprs,
+                             GetPgIndexDescriptor(),
+                             &isnull);
+   Assert(!isnull);
+   exprsString = TextDatumGetCString(exprsDatum);
+   rawExprs = (List *) stringToNode(exprsString);
+   pfree(exprsString);
+
+   /* Construct null Consts; the typlen and typbyval are arbitrary. */
+   result = NIL;
+   foreach(lc, rawExprs)
+   {
+       Node       *rawExpr = (Node *) lfirst(lc);
+
+       result = lappend(result,
+                        makeConst(exprType(rawExpr),
+                                  exprTypmod(rawExpr),
+                                  exprCollation(rawExpr),
+                                  1,
+                                  (Datum) 0,
+                                  true,
+                                  true));
+   }
+
+   return result;
+}
+
 /*
  * RelationGetIndexPredicate -- get the index predicate for an index
  *

diff --git a/src/include/catalog/index.h b/src/include/catalog/index.h
index 006b1801a3217cc34e283b4fc3cff2b8443f839c..0c9da61149bf1af388c50ae77349c90d66c44792 100644 (file)
--- a/src/include/catalog/index.h
+++ b/src/include/catalog/index.h
@@ -79,6 +79,8 @@ extern void index_drop(Oid indexId, bool concurrent);
 
 extern IndexInfo *BuildIndexInfo(Relation index);
 
+extern IndexInfo *BuildDummyIndexInfo(Relation index);
+
 extern void FormIndexDatum(IndexInfo *indexInfo,
               TupleTableSlot *slot,
               EState *estate,

diff --git a/src/include/utils/relcache.h b/src/include/utils/relcache.h
index e4ca70f1404c77ba12e47b01d073e3a1cd106f10..e7469e2fdcc6feb6f35a5e66b2de7614fb672e71 100644 (file)
--- a/src/include/utils/relcache.h
+++ b/src/include/utils/relcache.h
@@ -41,6 +41,7 @@ extern List *RelationGetIndexList(Relation relation);
 extern Oid RelationGetOidIndex(Relation relation);
 extern Oid RelationGetReplicaIndex(Relation relation);
 extern List *RelationGetIndexExpressions(Relation relation);
+extern List *RelationGetDummyIndexExpressions(Relation relation);
 extern List *RelationGetIndexPredicate(Relation relation);
 
 typedef enum IndexAttrBitmapKind

diff --git a/src/test/regress/expected/temp.out b/src/test/regress/expected/temp.out
index 0df7ba3ae1a3c0baa95d3d71254aaf2e9152a562..f491d6d30ed25df90cdb36360f96c5742db057fb 100644 (file)
--- a/src/test/regress/expected/temp.out
+++ b/src/test/regress/expected/temp.out
@@ -49,6 +49,8 @@ LINE 1: SELECT * FROM temptest;
                       ^
 -- Test ON COMMIT DELETE ROWS
 CREATE TEMP TABLE temptest(col int) ON COMMIT DELETE ROWS;
+-- while we're here, verify successful truncation of index with SQL function
+CREATE INDEX ON temptest(bit_length(''));
 BEGIN;
 INSERT INTO temptest VALUES (1);
 INSERT INTO temptest VALUES (2);

diff --git a/src/test/regress/sql/temp.sql b/src/test/regress/sql/temp.sql
index 6936b999295e8c6a928fcbf85cd9281788fe3283..b845bc05c7d360d99a011ca525b390d17df236df 100644 (file)
--- a/src/test/regress/sql/temp.sql
+++ b/src/test/regress/sql/temp.sql
@@ -55,6 +55,9 @@ SELECT * FROM temptest;
 
 CREATE TEMP TABLE temptest(col int) ON COMMIT DELETE ROWS;
 
+-- while we're here, verify successful truncation of index with SQL function
+CREATE INDEX ON temptest(bit_length(''));
+
 BEGIN;
 INSERT INTO temptest VALUES (1);
 INSERT INTO temptest VALUES (2);