open(2) flags saved for re-opening a virtual file should probably not

include O_CREAT.

diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
index 3250a35a0fac373403d5671e1dc44a54a7891831..3dd15e45d2fa729fdf5e62dacaaaf163cf224b69 100644 (file)
--- a/src/backend/storage/file/fd.c
+++ b/src/backend/storage/file/fd.c
@@ -112,7 +112,7 @@ typedef struct vfd
        long            seekPos;                /* current logical file position */
        char       *fileName;           /* name of file, or NULL for unused VFD */
        /* NB: fileName is malloc'd, and must be free'd when closing the VFD */
-       int                     fileFlags;              /* open(2) flags for opening the file */
+       int                     fileFlags;              /* open(2) flags for (re)opening the file */
        int                     fileMode;               /* mode to pass to open(2) */
 } Vfd;
 
@@ -681,8 +681,10 @@ fileNameOpenFile(FileName fileName,
        vfdP->fileName = malloc(strlen(fileName) + 1);
        strcpy(vfdP->fileName, fileName);
 
-       vfdP->fileFlags = fileFlags & ~(O_TRUNC | O_EXCL);
+       /* Saved flags are adjusted to be OK for re-opening file */
+       vfdP->fileFlags = fileFlags & ~(O_CREAT | O_TRUNC | O_EXCL);
        vfdP->fileMode = fileMode;
+
        vfdP->seekPos = 0;
 
        /*